Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CLA check #242

Merged
merged 1 commit into from
Oct 17, 2023
Merged

add CLA check #242

merged 1 commit into from
Oct 17, 2023

Conversation

delgod
Copy link
Member

@delgod delgod commented Oct 6, 2023

Check if Canonical's Contributor License Agreement has been signed by the PR author(s).

@delgod delgod marked this pull request as ready for review October 6, 2023 11:53
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #242 (740fa78) into main (51e4177) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files           9        9           
  Lines        1876     1876           
  Branches      309      309           
=======================================
  Hits         1516     1516           
  Misses        309      309           
  Partials       51       51

@taurus-forever
Copy link
Contributor

@delgod it looks like you are not passing CLA check.
BTW, any manuals how to sign it? We will need to give the link to community members PR us. :-D

@taurus-forever taurus-forever mentioned this pull request Oct 10, 2023
Merged
@marceloneppel
Copy link
Member

@delgod it looks like you are not passing CLA check. BTW, any manuals how to sign it? We will need to give the link to community members PR us. :-D

There is a manual on Juju about that: https://github.com/juju/juju/blob/3.3/CONTRIBUTING.md#contributor-licence-agreement

@delgod
add CLA check
740fa78 
Check if Canonical's Contributor License Agreement has
been signed by the PR author(s).

Signed-off-by: Mykola Marzhan <[email protected]>
taurus-forever
taurus-forever approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CC: @carlcsaposs-canonical should it be part of https://github.com/canonical/data-platform-workflows ?

@carlcsaposs-canonical
Copy link
Contributor

CC: @carlcsaposs-canonical should it be part of https://github.com/canonical/data-platform-workflows ?

no need imo—it's already a reusable action

@delgod delgod merged commit 572afce into main Oct 17, 2023
29 of 30 checks passed
@delgod delgod deleted the add-cla-check branch October 17, 2023 09:58
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
@delgod
add CLA check (canonical#242)
3d94eae 
Check if Canonical's Contributor License Agreement has
been signed by the PR author(s).

Signed-off-by: Mykola Marzhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@deusebio deusebio deusebio approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delgod @taurus-forever @marceloneppel @carlcsaposs-canonical @deusebio